[HTTPS-Everywhere] Implement build of specific branch in makexpi.sh

Eitan Adler lists at eitanadler.com
Fri Sep 30 20:45:17 PDT 2011


On Fri, Sep 30, 2011 at 10:50 PM, Alex Xu <alex_y_xu at yahoo.ca> wrote:
> Also cleaned up inaccurate documentation in makexpi.sh.
>
> Did basic testing and it appears to work.. decently.
>
> Probably needs some code cleanup before merge, though.

Some portability notes:

+       cp --recursive --archive .git $SUBDIR

Please use cp -r -a

+ mkdir --parents $XPI_NAME

Please use mkdir -p

+   printf >&2 "Total included rules: $(ls chrome/content/rules/*.xml
| wc -l)\n"

Don't script on ls: use find instead.

While here can you please fix the sed lines? it appears that they are
using some non-standard extensions (although this was not introduced
by your patch).


>
> _______________________________________________
> HTTPS-everywhere mailing list
> HTTPS-everywhere at mail1.eff.org
> https://mail1.eff.org/mailman/listinfo/https-everywhere
>
>



-- 
Eitan Adler



More information about the HTTPS-everywhere mailing list