[HTTPS-Everywhere] Shell cleanup

[Victor Engmark]

On Oct 7, 2011 1:53 PM, "Eitan Adler" <lists at eitanadler.com> wrote:
>
> On Fri, Oct 7, 2011 at 4:46 AM, Victor Engmark <victor.engmark at gmail.com>
wrote:
> > Hi all,
> >
> > I've done a bit of cleanup of the shell code:
> > <https://github.com/l0b0/https-everywhere/commits/master>
>
> find -wholename is not portable

Ok, but the old code AFAICT didn't do anything useful. OTOH, Alex' changes
are much more useful.

> +1 to the $fail changes
>
> -[ -n "$1" ] && cd "$1"
> +cd "${1:-.}"
>
> Microoptimization?

It's shorter, IMO clearer, and yes, if it wasn't for those reasons, a
useless microoptimization.

Cheers,
V
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.eff.org/pipermail/https-everywhere/attachments/20111007/80f63801/attachment.html>