[HTTPS-Everywhere] Shell cleanup

Eitan Adler lists at eitanadler.com
Fri Oct 7 04:52:58 PDT 2011


On Fri, Oct 7, 2011 at 4:46 AM, Victor Engmark <victor.engmark at gmail.com> wrote:
> Hi all,
>
> I've done a bit of cleanup of the shell code:
> <https://github.com/l0b0/https-everywhere/commits/master>

find -wholename is not portable

+1 to the $fail changes

-[ -n "$1" ] && cd "$1"
+cd "${1:-.}"

Microoptimization?

>
> I'd like to do more, but it would be nice to know whether these
> changes are acceptable, and if not, why. If they are acceptable,
> you're welcome to pull.
>
> --
> Victor Engmark
> _______________________________________________
> HTTPS-everywhere mailing list
> HTTPS-everywhere at mail1.eff.org
> https://mail1.eff.org/mailman/listinfo/https-everywhere
>



-- 
Eitan Adler



More information about the HTTPS-everywhere mailing list