[PrivacyBadger] Syncing firstRun HTML and CSS across the firefox and chrome repos

Cooper Quintin cooperq at eff.org
Thu May 8 16:06:15 PDT 2014


+1 for simplifying and cleaning up the directory layout for chrome. 
This is also in line with my goals to eventually get rid of the adblock
plus code (or at least reduce it as much as possible.)


On 05/08/2014 04:03 PM, Garrett Robinson wrote:
>> Are those files compatible enough that there's a directory we can just forcibly sync over to the Firefox tree?
> Unfortunately, doing so is non-trivial since the directory structures are radically different. Everything in the Firefox extension is contained in either data/ or data/skin. The Chrome extension's assets are scattered between adblockplus/chrome/content/ui/, adblockplus/chrome/skin/, and I believe some other locations as well. If we unified/simplified the location of assets in the Chrome extension, then this might be possible. The Firefox arrangement could be changed a little as well. The distinction between data/firstRun.html and data/skin/* doesn't really make sense to me. It would probably be clearer just to put everything in a data/firstrun directory.
>
> I would encourage this consolidation in both repos so we can minimize developer time spent manually sync'ing these assets in the future :)
> _______________________________________________
> PrivacyBadger mailing list
> PrivacyBadger at eff.org
> https://lists.eff.org/mailman/listinfo/privacybadger
>



More information about the PrivacyBadger mailing list