[HTTPS-Everywhere] https-everywhere bug with channels not attached to a window
Loic J. Duros
lduros at gnu.org
Sun May 13 17:22:56 PDT 2012
On 05/13/2012 08:08 PM, Peter Eckersley wrote:
> On Sat, May 12, 2012 at 06:31:25PM -0400, Loic J. Duros wrote:
>
>> Ah, got it. Thanks for pointing out that the issue is the same. I'm
>> able to see that the https-everywhere-uri-rewrite notification is
>> triggered on some sites, but I don't have yet a clear idea how I
>> would update my xhr after the channel has been replaced. Justin
>> Samuel in RequestPolicy checks with the content policy "shouldLoad"
>> if the current url has a mapping, which would show it has been
>> rewritten. However, in the case of the xhr, my guess is that I'd
>> have to update the original nsIHttpChannel? Not sure how to do this
>> yet, but in any case, many thanks for your help.
> Would it help if we sent an https-everywhere-uri-rewrite2 notification which
> actually gives you a new nsIHTTPChannel that replaces the previous one?
I can't tell for sure yet. Currently I'm just creating a new request
with the updated URI. It seems to work fine, so the latest dev version
of Https Everywhere is already a huge improvement! There's an
xhr.channel property available so maybe there's a way to update it. I'll
look into it some more...
Many thanks for all your help so far! :-)
More information about the HTTPS-everywhere
mailing list