[HTTPS-Everywhere] Implement build of specific branch in makexpi.sh

Alex Xu alex_y_xu at yahoo.ca
Sat Oct 1 10:32:49 PDT 2011


Increased portability and efficiency. Also removed "multi-line comment"
on trivial-validate included for testing; forgot to remove in last diff.

On 11-09-30 11:45 PM, Eitan Adler wrote:
> On Fri, Sep 30, 2011 at 10:50 PM, Alex Xu <alex_y_xu at yahoo.ca> wrote:
>> Also cleaned up inaccurate documentation in makexpi.sh.
>>
>> Did basic testing and it appears to work.. decently.
>>
>> Probably needs some code cleanup before merge, though.
> 
> Some portability notes:
> 
> +       cp --recursive --archive .git $SUBDIR
> 
> Please use cp -r -a
> 
> + mkdir --parents $XPI_NAME
> 
> Please use mkdir -p
> 
> +   printf >&2 "Total included rules: $(ls chrome/content/rules/*.xml
> | wc -l)\n"
> 
> Don't script on ls: use find instead.
> 
> While here can you please fix the sed lines? it appears that they are
> using some non-standard extensions (although this was not introduced
> by your patch).
> 
> 
>>
>> _______________________________________________
>> HTTPS-everywhere mailing list
>> HTTPS-everywhere at mail1.eff.org
>> https://mail1.eff.org/mailman/listinfo/https-everywhere
>>
>>
> 
> 
> 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: makexpi.diff.2
URL: <http://lists.eff.org/pipermail/https-everywhere/attachments/20111001/8e8fecda/attachment.ksh>


More information about the HTTPS-everywhere mailing list