[HTTPS-E Rulesets] Twitter ruleset example should use non-capturing group
Johan
eentotenmetdrie at gmail.com
Sat Feb 14 01:03:27 PST 2015
Hello everybody,
I just noticed the Twitter ruleset example at
https://www.eff.org/https-everywhere/rulesets is using a capturing group,
(www\.), but doesn't use result matched by the group.
It should be changed to a non-capturing group (which has better
performance) so people writing a ruleset won't make the same mistake.
Current ruleset
<ruleset name="Twitter">
<target host="www.twitter.com" />
<target host="twitter.com" />
<rule from="^http://(www\.)?twitter\.com/" to="https://twitter.com/"/>
</ruleset>
Fixed
<ruleset name="Twitter">
<target host="www.twitter.com" />
<target host="twitter.com" />
<rule from="^http://(*?:*www\.)?twitter\.com/" to="https://twitter.com/"/>
</ruleset>
(Non-capturing groups start with *?:*.)
Regards,
Johan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.eff.org/pipermail/https-everywhere-rules/attachments/20150214/1a4328b7/attachment.html>
More information about the HTTPS-Everywhere-Rules
mailing list