[HTTPS-E Rulesets] Help creating a rule

[Peter Eckersley]

Indeed it didn't.  Turns out there were several more bugs lurking in there.
They should actually be fixed now.

On Mon, Jan 28, 2013 at 01:26:08PM -0800, Finnian Herzfeld wrote:
> Didn't work. I got this error when running the makecrx.sh script:
> 
> src/chrome/content/rules/Zumzi.xml validates
> src/chrome/content/rules/Zynga.xml validates
> Validation of rulesets with RELAX NG grammar completed.
> Creating ruleset library...
> Traceback (most recent call last):
>   File "./utils/merge-rulesets.py", line 30, in <module>
>     commit_id = os.environ["GIT_COMMIT_ID"]
>   File "/usr/lib/python2.7/UserDict.py", line 23, in __getitem__
>     raise KeyError(key)
> KeyError: 'GIT_COMMIT_ID'
> cp: omitting directory `src/'
> Total included rules: 5551
> Rules disabled by default: 1126
> Created pkg/https-everywhere-2013.1.3~pre.crx
> 
> 
> 
> Finn Herzfeld
> 
> 
> 
> On Mon, Jan 28, 2013 at 1:14 PM, Peter Eckersley <pde at eff.org> wrote:
> 
> > Your ruleset looks okay to me. In fact, you just noticed that I'd broken
> > the
> > chrome build script in git master.
> >
> > Running "git pull" and trying again should fix the problem.
> >
> > On Mon, Jan 28, 2013 at 11:54:58AM -0800, Finnian Herzfeld wrote:
> > > I am apparently incapable of creating a simple rule, so some help would
> > be
> > > appriciated. I cloned the git repository, added a new .xml file
> > > to src/chrome/content/rules/ using the make-trivial-rule script and
> > > adjusted it to look like this:
> > >
> > > <ruleset name="Edugen.wileyplus.com">
> > >   <target host="edugen.wileyplus.com" />
> > >   <rule from="^http://edugen\.wileyplus\.com/" to="
> > > https://edugen.wileyplus.com/" />
> > > </ruleset>
> > >
> > > Then I went back to the root of the git foler and ran ./makecrx.sh and
> > > dropped the resulting .crx file into chrome. I proceeded to visit
> > > edugen.wileyplus.com and was not redirected to the https version of the
> > > page. I tried getting there different ways, disabling the official https
> > > everywhere, etc. Nothing. What am I doing wrong?
> > > Finn Herzfeld
> >
> > --
> > Peter Eckersley                            pde at eff.org
> > Technology Projects Director      Tel  +1 415 436 9333 x131
> > Electronic Frontier Foundation    Fax  +1 415 436 9993
> >

-- 
Peter Eckersley                            pde at eff.org
Technology Projects Director      Tel  +1 415 436 9333 x131
Electronic Frontier Foundation    Fax  +1 415 436 9993