[HTTPS-E Rulesets] Patches to Finnish sites

[Peter Eckersley]

In theory everything should be unix encoded, but occasionally we get
contributions from people using git on Windows, which we haven't been checking
for or changing.

Annoyingly some of the JS files in the tree that came from NoScript also use
Windows newlines (and need to, so that we can merge changes from upstream in a
sane manner).

We haven't had a policy on this until now, and it seems best to avoid one if
we can get away with it.  I still haven't confirmed that that was the real
problem with your patches; I tried various newline tweaks and none of them
have worked.

Can you try making a remote on github and pushing to it?

On Tue, Dec 18, 2012 at 06:53:17PM +0200, Mikko Harhanen wrote:
> Sorry about the trouble, I did not check them for whitespace errors.
> 
> I wanted to find out what I did wrong so I started inspecting the
> rule files. I noticed that most of the files are in Unix text file
> format but not all of them. I searched through the files and found
> 42 rules that handle line endings differently.
> 
> Here is a link to the list: http://pastebin.com/raw.php?i=2mqv5nGW
> 
> Do you have a policy about these line ending characters? Should I
> continue with the DOS format if the file uses it or should I convert
> them?
> 
> On 17/12/12 21:06, Peter Eckersley wrote:
> >Is there any chance I can get you to push these to a git
> >remote?  For some reason that I haven't yet figured out, git
> >am/git apply is refusing to apply them for me.  Possibly
> >newline weirdness, I'm not sure.
> 

-- 
Peter Eckersley                            pde at eff.org
Technology Projects Director      Tel  +1 415 436 9333 x131
Electronic Frontier Foundation    Fax  +1 415 436 9993