[HTTPS-E Rulesets] Updates to Google.xml

[Osama Khalid]

On Tue, Jan 18, 2011 at 03:28:55PM -0800, Peter Eckersley wrote:
> > +  <!-- Firefox homepage isn't currently available in HTTPS.-->
> > +  <rule from="^http://(www\.)?google\.com/firefox/?" 
> >            to="https://encrypted.google.com/webhp"/>
> 
> I presume the "/?" here is a bug?  The similar preexisting construction was
> "/?$" , which would only strip a slash if it the last character in the URI.  

The old pattern used to perform search on URLs like:
http://www.google.com/firefox?q=a
http://www.google.com/firefox/?q=a

But Google actually considers the Firefox home page equivalent to
'webhp': Google home page without search. The new pattern carries on
Firefox home page parameters into the encrypted one.  (check note #3)

> >    <rule 
> > -    from="^http://(www\.)?google\.[^/@:][^/@:]/(search\?|firefox|#)" 
> > +    from="^http://(www\.)?google(\.com?)?(\.[^/@:][^/@:])?/(search\?|#)" 
> >        to="https://encrypted.google.com/#" />
> 
> I may retain two rules in this section.  Readability is more important than
> minimising the number of regexps, I think.

Well, I wonder if it's too ugly/complex. ;) It does require people to
have basic regex understanding but it's actually clear.

--Osama Khalid